Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upscale improvements #428

Closed
smilesrg opened this issue May 14, 2014 · 2 comments
Closed

Upscale improvements #428

smilesrg opened this issue May 14, 2014 · 2 comments
Labels
Level: Bug 🐞 This item involves a legitimate regression (bug) to existing functionality. Level: New Feature 🆕 This item involves the introduction of new functionality.

Comments

@smilesrg
Copy link

Is it possible to add parameters for upscale like max[x,y], exact[x, y] and crop? Because currently it is not possible to upscale rectangle image to square with cropping using upscale filter. To achieve this behaviour, I had to downgrade to v0.11.1 and use thumbnails filter with allow_upscale set to true.

@makasim makasim added this to the v1.1 milestone May 22, 2014
@petesiss
Copy link

I think I'm finding the same issue - that currently irrespective of mode or allow_upscale, smaller images of different aspect ratios can not be upscaled to a guaranteed size and aspect ratio using the thumbnail filter alone.

This chaining seems to work though (makes the allow_upscale redundant):

        core_grid:
            filters:
                upscale: { min: [250, 220] }
                thumbnail: { size: [250, 220], mode: outbound, allow_upscale: true  }

@robfrawley robfrawley removed this from the v1.1-missed milestone Jan 25, 2017
@michellesanver
Copy link
Contributor

I believe this is fixed already.

#1015

If this is still an issue for you, please open a new PR with more information :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: Bug 🐞 This item involves a legitimate regression (bug) to existing functionality. Level: New Feature 🆕 This item involves the introduction of new functionality.
Projects
None yet
Development

No branches or pull requests

5 participants