GridFSLoader bug

[npinon]

Since the update of mongodb-odm package (661a3b3) I have this error :

Fatal error: Call to a member function getCollection() on a non-object in /vendor/liip/imagine-bundle/Liip/ImagineBundle/Imagine/Data/Loader/GridFSLoader.php on line 48

It happened when I try to load an image from mongogridfs.

Maybe something has changed.
Can someone correct the problem?

[havvg]

Please give us the exact versions you were using and you are using now.

[npinon]

Now I use :

        "doctrine/mongodb-odm" : "dev-master#bbcfedf",
        "doctrine/mongodb-odm-bundle" : "dev-master",
        "liip/imagine-bundle": "dev-master",

I have forced an old version of mongodb-odm and it worked.

With the commit 661a3b3 of mongodb-odm I had the bug above.

[peterrehm]

@npinon Have you found a solution? Same appears on my side.

[peterrehm]

It seems that changing the GridFsLoader::find() method with the following fixes the issue:

/**
 * {@inheritDoc}
 */
public function find($id)
{
    $image = $this->dm
        ->getRepository($this->class)
        ->find(new \MongoId($id));

    if (!$image) {
        throw new NotFoundHttpException(sprintf('Source image not found with id "%s"', $id));
    }

    return $this->imagine->load($image->getFile()->getBytes());
}

[npinon]

Looks nice!
Thx

[havvg]

@npinon Can you confirm, the changes solve this issue?

[npinon]

I confirm. It works!

[peterrehm]

@havvg Could you consider tagging a minor bugfix release?

[havvg]

Already done, https://github.com/liip/LiipImagineBundle/releases/tag/v0.20.2

[peterrehm]

Oh thanks. I have not seen that since GitHub was collapsing the 6 other releases. In the rush I just saw last release 3 months ago. 👍

[npinon]

Reopen.
There's a problem with the correction. You must reload a page to view images generated by the bundle (find vs findOne).
I solved the problem with this commit.

[peterrehm]

@npinon What is the difference? Dont understand what you mean with reload.

[npinon]

@peterrehm find didn't return the correct objet (instead of findOne) but the cache image is generated. So when you load the page for the first time nothing is displayed, but when you reload the cache image is displayed.

[peterrehm]

@npinon What is the difference? It should return the same object. It worked for me without any problems.

[npinon]

I'm sorry, I just checked and you're right.
I don't have the problem anymore. It's weird...