Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail with fixed size #1181

Closed
yoannk opened this issue May 23, 2019 · 8 comments
Closed

Thumbnail with fixed size #1181

yoannk opened this issue May 23, 2019 · 8 comments

Comments

@yoannk
Copy link

yoannk commented May 23, 2019

How to create a thumbnail with fixed size in version 2.1.0 ?
I tried with allow_upscale but it has no effect

filters:
    thumbnail:
         size: [800,530]
         mode: outbound
         allow_upscale: true

I tried with fixed filter : https://symfony.com/doc/1.0/bundles/LiipImagineBundle/filters/sizing.html#fixed-size
but this filter is not present in version 2.1

@franmomu
Copy link
Contributor

Maybe this has to do with #560

@damienalexandre
Copy link

There is a "fixed" filter bypassing the "allow upscale" bug, but it as only been merged in 1.0 and is not available on 2.0 so far.

See #1015

Maybe @peter-gribanov knows why?

@peter-gribanov
Copy link
Contributor

Not. I don't know why this feature was not merged into version 2.x.
Perhaps maintainers know this @lsmith77 @antoligy @robfrawley @maximgubar

@maximgubar
Copy link
Contributor

@peter-gribanov, just fyi, I'm not a maintainer anymore :)

@franmomu
Copy link
Contributor

franmomu commented Sep 1, 2019

So the "fixed" filter will be available again in the next release of this bundle.

@michellesanver
Copy link
Contributor

I'm a maintainer now, just getting into everything; sorry if it's slow. Thanks all. Does this solve your issue @nkoyan ?

@yoannk
Copy link
Author

yoannk commented Oct 4, 2019

I still have the same issue with 2.2.0 version :
Uncaught PHP Exception InvalidArgumentException: "Could not find filter(s): "fixed""

@franmomu
Copy link
Contributor

franmomu commented Oct 4, 2019

Oops maybe it is not loaded as a service in the xml, I could take a look later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants