Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a fast-path for attribute.Set metrics API usage #448

Open
jmacd opened this issue May 4, 2023 · 0 comments
Open

Write a fast-path for attribute.Set metrics API usage #448

jmacd opened this issue May 4, 2023 · 0 comments

Comments

@jmacd
Copy link
Contributor

jmacd commented May 4, 2023

Is your feature request related to a problem? Please describe.
The OTel-Go metrics API v0.38 includes functional options to support use of precalculated attribute.Set objects. This will require a separate code path to be as optimized as the existing code path.

Describe the solution you'd like
Fortunately, the existing code structure makes this fairly straightforward. Because synchronous instrument state is aggregated without a uniqueness requirement, that is because synchronous instrument state is allowed to hold multiple copies of the same attribute set, a parallel data structure mapping attribute.Set to *record can be crafted. It will be simpler than the []attribute.KeyValue code path.

Describe alternatives you've considered
#447 installs a slow path workaround.

Additional context
See #446.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant