Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support batch-size limits for OTLP payloads from Lightstep metrics SDK #263

Closed
jmacd opened this issue Aug 31, 2022 · 1 comment
Closed

Comments

@jmacd
Copy link
Contributor

jmacd commented Aug 31, 2022

Is your feature request related to a problem? Please describe.
Because a single interval computes a single protocol message, there is no current feature allowing users to place limits on metrics size. Generally, this means when you overuse metrics you eventually reach a gRPC max-message-size limit.

Describe the solution you'd like
Batching by size is not an easy problem. I've seen https://pkg.go.dev/google.golang.org/api/support/bundler is one approach. (I developed something similar for Lightstep satellites.)

Simpler to batch by maximum point count and leave it to the user's attribute/resource size to determine max payload.

Describe alternatives you've considered
This is difficult to specify at the OTel level. The alternative is not to do this.

@jmacd
Copy link
Contributor Author

jmacd commented Jun 2, 2023

The batchprocessor is now supported, which splits large payloads.

@jmacd jmacd closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant