You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@xdrdak are we restricting this for a reason? Should we instead document how to override on the consumer-side and at that point recommend using deepmerge for example?
glambert
changed the title
deepmerge themes when overriding
Use deepmerge themes when overriding
Nov 4, 2019
Description
Provide a high-level summary of your issue.
flame/packages/flame/src/Core/index.tsx
Line 106 in de4b4c8
Rather than spreading both objects together, use deepmerge so that a new theme may extend the ThemeUI without fully overriding the original theme.
What do you think should have happened?
The
color
would be deepmerged. Instead thecolor
is overwritten by the ThemeOverrideSteps to reproduce the problem
Specifications
The text was updated successfully, but these errors were encountered: