We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While attempting to import the <Dropdown> component from Flame in the new insights app, we ran into a Typescript issue where the app wouldn't compile because children is not a valid prop in the Dropdown interface.
<Dropdown>
children
Dropdown
The insights app is using React 18 and in that version React.FC no longer includes children by default.
So any Flame components that
React.FC
Box
will probably need to be updated to be compatible with React 18 and TS.
<Dropdown> and other similar components that take children can be successfully used in a React 18 / Typescript project, like lighthouse-insights.
n/a
The text was updated successfully, but these errors were encountered:
ls-andrew-borstein
No branches or pull requests
Description
While attempting to import the
<Dropdown>
component from Flame in the new insights app, we ran into a Typescript issue where the app wouldn't compile becausechildren
is not a valid prop in theDropdown
interface.The insights app is using React 18 and in that version React.FC no longer includes
children
by default.So any Flame components that
React.FC
children
propchildren
or extend a type that does so (e.g.Box
)will probably need to be updated to be compatible with React 18 and TS.
Requirements
Dependencies
<Dropdown>
and other similar components that takechildren
can be successfully used in a React 18 / Typescript project, like lighthouse-insights.Required before signoff
n/a
Design/Examples
n/a
The text was updated successfully, but these errors were encountered: