Add the fromXdrBase64, fromXdrByteArray, toXdrBase64 and toXdrByteArray methods to the XDR classes.

[overcat]

What problem does your feature solve?

1. Currently, there is a large amount of template code in the current codebase. Moreover, as the project develops, similar template code may increase. I believe that we should generate corresponding methods in the XDR classes.
   Some examples:

• https://github.com/stellar/java-stellar-sdk/blob/25dc8a8fa3b38fc6a12fa212ee1b51665a113135/src/main/java/org/stellar/sdk/SorobanServer.java#L480-L516
• https://github.com/stellar/java-stellar-sdk/blob/25dc8a8fa3b38fc6a12fa212ee1b51665a113135/src/main/java/org/stellar/sdk/Util.java#L104-L162
• https://github.com/stellar/java-stellar-sdk/blob/25dc8a8fa3b38fc6a12fa212ee1b51665a113135/src/main/java/org/stellar/sdk/AbstractTransaction.java#L121-L133

2. When users use the getTransaction method to retrieve the result of a Soroban transaction, there are many XDRs that need to be parsed. Adding these two methods can facilitate users in parsing them.

What would you like to see?

Add the fromXdrBase64 and toXdrBase64 methods to the XDR classes.

diff --git a/src/main/java/org/stellar/sdk/xdr/AccountEntry.java b/src/main/java/org/stellar/sdk/xdr/AccountEntry.java
index 57ed904d..03be0dd1 100644
--- a/src/main/java/org/stellar/sdk/xdr/AccountEntry.java
+++ b/src/main/java/org/stellar/sdk/xdr/AccountEntry.java
@@ -6,6 +6,9 @@
 import static org.stellar.sdk.xdr.Constants.*;
 
 import com.google.common.base.Objects;
+import com.google.common.io.BaseEncoding;
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.util.Arrays;
 
@@ -227,6 +230,32 @@ public boolean equals(Object object) {
         && Objects.equal(this.ext, other.ext);
   }
 
+  @Override
+  public String toXdrBase64() throws IOException {
+    BaseEncoding base64Encoding = BaseEncoding.base64();
+    return base64Encoding.encode(toXdrByteArray());
+  }
+
+  @Override
+  public byte[] toXdrByteArray() throws IOException {
+    ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream();
+    XdrDataOutputStream xdrDataOutputStream = new XdrDataOutputStream(byteArrayOutputStream);
+    encode(xdrDataOutputStream);
+    return byteArrayOutputStream.toByteArray();
+  }
+
+  public static AccountEntry fromXdrBase64(String xdr) throws IOException {
+    BaseEncoding base64Encoding = BaseEncoding.base64();
+    byte[] bytes = base64Encoding.decode(xdr);
+    return fromXdrByteArray(bytes);
+  }
+
+  public static AccountEntry fromXdrByteArray(byte[] xdr) throws IOException {
+    ByteArrayInputStream byteArrayInputStream = new ByteArrayInputStream(xdr);
+    XdrDataInputStream xdrDataInputStream = new XdrDataInputStream(byteArrayInputStream);
+    return decode(xdrDataInputStream);
+  }
+
   public static final class Builder {
     private AccountID accountID;
     private Int64 balance;

What alternatives are there?

N/A

[overcat]

Let's track this issue here, I won't create an issue in the xdrgen repository.

I have prepared a PR, but let's wait for these PRs to be merged before I submit the new one.

• fix(java): Set the default maximum value for XdrString. stellar/xdrgen#159
• feat(java): render constants. stellar/xdrgen#160
• fix(java): fix name conflicts. stellar/xdrgen#161
• fix(java): Fix the representation of UnsignedInteger and UnsignedHyperInteger. stellar/xdrgen#163
• Correct the data type of certain fields to store the expected design values. #498

[sreuland]

@overcat, ok, so in xdrgen, you need stellar/xdrgen#159 stellar/xdrgen#160 stellar/xdrgen#161 and stellar/xdrgen#163 merged now regardless just to enable ongoing development in java sdk soroban feature branch? @tamirms , any chance you have checked any of these xdrgen pr's yet, I will as well, but don't have much experience there.

and then after those xdrgen all merge, this remainder request for optimizing Base64 methods can be considered, but it's not blocking?

[overcat]

These changes(stellar/xdrgen#159 stellar/xdrgen#160 stellar/xdrgen#161) have been applied to #481.
The changes(stellar/xdrgen#163) have been applied to #498.

These changes are all small, and I believe we can quickly review them.

If I want to create a PR for this issue, it will result in changes to XDR. However, there are also changes to XDR in #498. This is not a big problem, but I prefer to wait for these PRs to be merged before creating a new one.