From 2b4de46c72ffd6ee164bd9c77a6cd7059827d7ce Mon Sep 17 00:00:00 2001 From: Elle Mouton Date: Tue, 24 Jan 2023 09:05:59 +0200 Subject: [PATCH] kvdb+docs: remove etcd test fixture cleanup calls Remove the cleanup calls which no longer exist since `t.Cleanup` is now called from within `NewEtcdTestFixture` --- docs/release-notes/release-notes-0.16.0.md | 3 +++ kvdb/etcd/db_test.go | 1 - kvdb/etcd_test.go | 1 - 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/release-notes/release-notes-0.16.0.md b/docs/release-notes/release-notes-0.16.0.md index da96b8f464..7757b8d47e 100644 --- a/docs/release-notes/release-notes-0.16.0.md +++ b/docs/release-notes/release-notes-0.16.0.md @@ -228,6 +228,9 @@ data. * [Add Custom Message to the fuzz testsuite in the lnwire package](https://github.com/lightningnetwork/lnd/pull/7303) +* [Remove non-existent Cleanup calls from etcd test code in the `kvdb` + package](https://github.com/lightningnetwork/lnd/pull/7352) + ## `lncli` * [Add an `insecure` flag to skip tls auth as well as a `metadata` string slice diff --git a/kvdb/etcd/db_test.go b/kvdb/etcd/db_test.go index 2bbd7df5cb..59e29fc94a 100644 --- a/kvdb/etcd/db_test.go +++ b/kvdb/etcd/db_test.go @@ -81,7 +81,6 @@ func TestNewEtcdClient(t *testing.T) { t.Parallel() f := NewEtcdTestFixture(t) - defer f.Cleanup() client, ctx, cancel, err := NewEtcdClient( context.Background(), f.BackendConfig(), diff --git a/kvdb/etcd_test.go b/kvdb/etcd_test.go index aae1653188..ec8e93f742 100644 --- a/kvdb/etcd_test.go +++ b/kvdb/etcd_test.go @@ -158,7 +158,6 @@ func TestEtcd(t *testing.T) { t.Parallel() f := etcd.NewEtcdTestFixture(t) - defer f.Cleanup() test.test(t, f.NewBackend(doRwLock))