Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macaroon-specific tests #284

Closed
4 tasks
aakselrod opened this issue Aug 28, 2017 · 2 comments · Fixed by #1152
Closed
4 tasks

Add macaroon-specific tests #284

aakselrod opened this issue Aug 28, 2017 · 2 comments · Fixed by #1152
Labels
authentication beginner Issues suitable for new developers gRPC macaroons P4 low prio security General label for issues/PRs related to the security of the software

Comments

@aakselrod
Copy link
Contributor

aakselrod commented Aug 28, 2017

The macaroon code needs some tests! Some ideas for things to test include:

  • Authenticating to one macaroon service with the macaroon of another service, with no macaroon, or with an invalid macaroon
  • Authenticating using permissions that are denied or allowed in various ways
  • Authenticating with macaroons containing expired and non-expired TimeBeforeCaveat
  • Doing all of the above in both lnd integration tests (with and without lncli, thanks @mrwhythat) and package-level unit tests
@Roasbeef Roasbeef added authentication beginner Issues suitable for new developers gRPC macaroons security General label for issues/PRs related to the security of the software labels Aug 28, 2017
@yashbhutwala
Copy link

Is anyone else working on this issue? If not, I can take a stab at it.

@merehap
Copy link

merehap commented Apr 16, 2018

I'll take up the unit testing portion of this under the assumption that @yashbhutwala and @mrwhythat are no longer looking at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication beginner Issues suitable for new developers gRPC macaroons P4 low prio security General label for issues/PRs related to the security of the software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants