Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Dual Funding (v2 Channel Establishment protocol) #524

Closed
wants to merge 44 commits into from
Closed

WIP: Dual Funding (v2 Channel Establishment protocol) #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
944bcce
features: add option for dual funding
niftynei Dec 3, 2018
5a748ae
peer: add v2 for open_channel
niftynei Dec 5, 2018
a119f07
peer-protocol: remove commitment_signed2 message
niftynei Feb 6, 2019
5b1e873
transactions: add calculations for dual funded funding_tx
niftynei Feb 6, 2019
4b14656
funding transaction: add test scripts for dual funding
niftynei Mar 7, 2019
8cc738f
dual funding: change confusing *- wording to []
niftynei Mar 7, 2019
bc25b0c
dual funding: add prevtx_scriptpubkey to `funding_compose`
niftynei Mar 7, 2019
edab8c8
dual funding: update language around change outputs
niftynei Mar 7, 2019
f68563c
dual funding: locking script -> scriptPubKey
niftynei Mar 7, 2019
dbf14a6
dual funding: use varint for tlv length
niftynei Apr 2, 2019
50a2964
fixup link
niftynei Apr 25, 2019
8b89f2a
transactions: add non input-output weight for funding transaction
niftynei Apr 29, 2019
3604294
fixup: rename 'funding_tx_id' to 'funding_txid'
niftynei Apr 30, 2019
4b5be7b
fixup: reorder `push_msat` so it's same as original `open_channel`
niftynei Apr 30, 2019
0928b73
fixup: include prev_scriptpubkey in example inputs
niftynei Apr 30, 2019
895f945
dual-funding: have the opener send the `contrib_count` at open
niftynei Apr 30, 2019
d2de360
dual-funding: move the `channel_reserve_satoshi` field
niftynei Apr 30, 2019
25ca2b1
dual-funding: add requirement for zero htlc's in commit_sig
niftynei May 4, 2019
bcbf7c7
dual-funding: fixup, move the wording to the right place
niftynei May 4, 2019
e5af0d5
dual-funding: add note about failing if contrib_count is wrong
niftynei May 4, 2019
e067a61
dual-funding: fixup egregious weight calculation in Appendix
niftynei May 4, 2019
4db44fc
dual-funding: note about when we switch from temp to 'real' channel_id
niftynei May 6, 2019
d8f3a11
fixup: spacing error with contrib-count
niftynei Jun 24, 2019
14b55f9
dual-funding: remove the funding_locked2 message
niftynei Jul 11, 2019
363ca15
fixup: update types to new represenations
niftynei Jul 11, 2019
04c9fd2
fixup: rename 'satoshis' so our checks work
niftynei Jul 15, 2019
65ee3db
revert later: make opener->funder so BOLT checks pass
niftynei Jul 15, 2019
eb7d517
fixup length count and update transaction with new data
niftynei Aug 21, 2019
3a3e4ff
df: remove contribution count, fix at 4.
niftynei Sep 9, 2019
c06d7b7
df: remove channel_reserve_satoshis from openchannel2
niftynei Sep 9, 2019
140ab5b
df: add separate tlv type for accept_channel2
niftynei Sep 11, 2019
6ab6758
df: remove funding_signed; replace with accepter_sigs
niftynei Sep 11, 2019
d1df2a1
update feature number briefly
niftynei Sep 19, 2019
afbf8d2
dual funding: break up funding composition messages
niftynei Oct 15, 2019
a233f57
dual-funding: fixup some wording on the RBF section
niftynei Oct 15, 2019
5dd384a
dual-funding: reduce total input/outputs from the accepter
niftynei Oct 28, 2019
40c0b80
fixup: wording, spelling and logic/duplication errors
niftynei Nov 13, 2019
761bc13
df: clarify handling of dust-limit for funding tx
niftynei Nov 14, 2019
c2de44f
df: normalize type numbers
niftynei Nov 21, 2019
8c92423
cleanup duplicative omit message
niftynei Nov 26, 2019
8aca867
add note about ignoring bad funding_signed2 msg
niftynei Nov 26, 2019
a960a1b
fixup! remove invalid requirement
niftynei Nov 26, 2019
5800879
fixup: remove redundant/verbose wording
niftynei Jan 28, 2020
2e40838
df: clarify that an input cannot be malleable and add new restriction
niftynei Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .aspell.en.pws
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,30 @@ delayedsig
hopDataSize
I'th
segwit
SegWit
sizeof
varint
tlv
rbf
RBF
accepter
accepter's
subtype
subsubtype
redeemScript
UTXO
utxo
scriptPubkey
scriptPubKey
scriptPubKeys
RBFs
ack'd
scriptlen
btc
sats
prevoutnum
prevtxid
ints
htlc
htlcs
ChaCha
Expand Down Expand Up @@ -375,3 +399,5 @@ GitHub
IRC
bitmasks
CSPRNG
workflow
PUSHDATA
Loading