Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to Custodian.inspectWalletTx to avoid re-inserting existing asset into local db #699

Closed
ffranr opened this issue Nov 27, 2023 · 1 comment · Fixed by #836
Closed
Labels
enhancement New feature or request

Comments

@ffranr
Copy link
Contributor

ffranr commented Nov 27, 2023

Custodian.inspectWalletTx should check to see if an asset (coin) and its corresponding proof already exists in the local db before attempting to import again. This method is actually call before the Custodian event loop here. At that point, on tapd restart, all wallet transactions are re-inspected.

We should also refactor the events cache so that it's a thread safe events processing queue. This is because events added during the custodian lifetime are handled synchronously and are not cleaned up from the events cache. And the current form of events is difficult to refactor.

@guggero
Copy link
Member

guggero commented Mar 22, 2024

Fixed by #836 by skipping already completed events.

@guggero guggero linked a pull request Mar 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants