Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[universes] add validation to prevent universe from adding federation connection with itself / loopback #350

Closed
dstadulis opened this issue Jun 9, 2023 · 0 comments · Fixed by #364
Closed

[universes] add validation to prevent universe from adding federation connection with itself / loopback #350

dstadulis opened this issue Jun 9, 2023 · 0 comments · Fixed by #364
Assignees
@guggero
Labels
enhancement New feature or request good first issue Good for newcomers universe

Comments

@dstadulis
Copy link
Collaborator

Currently, it's possible for federations to erroneously/needlessly add their own address as a federation member. This behavior is errant and can cause unnecessary resource consumption.

the federation addition code should be modified to validate that the universe endpoint / resource being added is not itself.
@dstadulis dstadulis added enhancement New feature or request good first issue Good for newcomers labels Jun 9, 2023
@dstadulis dstadulis moved this from 🆕 New to 🔖 Ready in Taproot-Assets Project Board Jun 10, 2023
@guggero guggero self-assigned this Jun 14, 2023
@dstadulis dstadulis moved this from 🔖 Ready to 🏗 In progress in Taproot-Assets Project Board Jun 14, 2023
@guggero guggero mentioned this issue Jun 15, 2023
Merged
@dstadulis dstadulis moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Jun 19, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guggero guggero

Labels
enhancement New feature or request good first issue Good for newcomers universe
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

universe: add server info RPC, check we're not connecting to ourselves lightninglabs/taproot-assets
2 participants
@guggero @dstadulis