Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature]: add channel conditional validation to AddAsset*Order RPC endpoints #1053

Closed
ffranr opened this issue Jul 31, 2024 · 1 comment · Fixed by #1192
Closed

[feature]: add channel conditional validation to AddAsset*Order RPC endpoints #1053

ffranr opened this issue Jul 31, 2024 · 1 comment · Fixed by #1192
Assignees
@guggero
Labels
enhancement New feature or request gRPC P2 rfq
Milestone
v0.5

Comments

@ffranr
Copy link
Contributor

ffranr commented Jul 31, 2024

Currently, the AddAssetBuyOrder and AddAssetSellOrder RPC endpoints initiates the RFQ communication process with a specified target peer. This issue proposes a modification to the endpoint to include a pre-condition check. Specifically, the RFQ process should only commence if there is an existing tap channel for the specified asset between the local node and the target peer, and that channel has sufficient funds. If these conditions are not met, the endpoints should return a helpful error.
@ffranr ffranr added enhancement New feature or request gRPC rfq labels Jul 31, 2024
@ffranr ffranr mentioned this issue Jul 31, 2024
Closed
@dstadulis dstadulis moved this from 🆕 New to 🏗 In progress in Taproot-Assets Project Board Jul 31, 2024
@dstadulis dstadulis moved this from 🏗 In progress to 🔖 Ready in Taproot-Assets Project Board Jul 31, 2024
@dstadulis dstadulis added this to the v0.4.1 milestone Jul 31, 2024
@dstadulis
Copy link
Collaborator

RFQ rework is a prerequisite

@Roasbeef Roasbeef added the P2 label Aug 27, 2024
@guggero guggero mentioned this issue Nov 14, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Taproot-Assets Project Board Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guggero guggero

Labels
enhancement New feature or request gRPC P2 rfq
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
v0.5
Development

Successfully merging a pull request may close this issue.

[rfq]: add validation to AddAssetBuyOrder and AddAssetSellOrder RPCs lightninglabs/taproot-assets
4 participants
@Roasbeef @guggero @ffranr @dstadulis