-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]: Ensure Golang Version 1.22.3 for make release
Command to Reproduce Release Manifest
#1045
Comments
Useful snippets: Modification to
|
While we're at it, maybe also check for unclean working directory? Something like:
|
You can have Go download and manage certain versions: https://go.dev/doc/manage-install There's also this: https://go.dev/doc/toolchain, which lets you add an env variable |
Re coveralls:
cc @jharveyb |
Thanks, that's good to know. I'm keen on adding |
Description:
The overall goal is to be able to reproduce a release manifest file. In order to reproduce the digest hashes in the manifest file of a given release, the correct Golang version must be used when building the binaries. Therefore, the
make release
command needs to assert the correct Golang version. If the Golang version is incorrect, the command should exit with an error message.Considerations and Modifications:
GO_VERSION = 1.22.3
.GO_VERSION
to./scripts/release.sh build-release
inmake release
../scripts/release.sh
to ensure that the correct version of Golang is used../scripts/release.sh
, the script should skip the version check../scripts/release.sh build-release
inmake release
is consistent with the version used in.github/workflows/release.yaml
(this check is already in place and does not require modifications as part of this issue).Acceptance Criteria:
make release
should use Golang version 1.22.3 (current go version stipulated in theMakefile
).The text was updated successfully, but these errors were encountered: