Inconsistent status and recovery for loops with double payment

[darbon]

We did two swaps where we paid twice (one manually and one automatically done by loop itself). Both swaps actually went through successfully.

One of the swaps had trouble finishing to SUCCESS status, and eventually reached FAILED status (reason FAILURE_REASON_TEMPORARY). That swap has actually recovered the funds from the double pay through a timeout tx. Also, even though the swap is FAILED and already recovered the double pay, it's still trying to send more recovery transactions every time we restart loop.

The other swap has SUCCESS status but never tried recovering the funds. We eventually had to recover the funds with "chantools recoverloopin". That swap seems settled by loop since it's not trying to recover the double pay.

Let us know if you need more logs or other information from the servers.

PS: Also to avoid this issue, maybe when creating a loop it should say clearly when it's going to be paid by loop, and when it requires external funding, since we got confused by this :)