Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add time limit on switch to second handshake #406

Closed
ellemouton opened this issue Aug 18, 2022 · 0 comments · Fixed by #408
Closed

add time limit on switch to second handshake #406

ellemouton opened this issue Aug 18, 2022 · 0 comments · Fixed by #408
Assignees
@ellemouton

Comments

@ellemouton
Copy link
Member

ellemouton commented Aug 18, 2022 •
edited
Loading

With nodes that have updated to using second handshake for LNC connection we should set a deadline for the initial, pass phrase based, connection. So if a user creates a new session and gets a passphrase for it but then doesnt make an initial connection in a timely manner, then the session should be force-revoked.

more context here: #401 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellemouton ellemouton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

multi: add deadline for first connection of new LNC conn ellemouton/lightning-terminal
1 participant
@ellemouton