Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to grpc v1.42.0 breaks client interceptor #62

Closed
carlaKC opened this issue Dec 13, 2021 · 0 comments · Fixed by #102
Closed

Upgrade to grpc v1.42.0 breaks client interceptor #62

carlaKC opened this issue Dec 13, 2021 · 0 comments · Fixed by #102

Comments

@carlaKC
Copy link
Contributor

carlaKC commented Dec 13, 2021

In lightninglabs/loop/pull/445, I bumped the following dependencies by mistake:

google.golang.org/grpc v1.38.0 -> google.golang.org/grpc v1.42.0
google.golang.org/protobuf v1.26.0 -> google.golang.org/protobuf v1.27.1

This caused all paywalled aperture apis to fail with rpc error: code = Unknown desc = cannot initiate swap: unexpected HTTP status code received from server: 402 (Payment Required), despite the interceptor being active (confirmed with ad-hoc logging).

This is not an issue at present, since we have no pressing need to upgrade.
Should we decide to upgrade lnd/loop/pool/lit, we will need to remember to upgrade aperture as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

proxy: always return 200 status code to gRPC client lightninglabs/aperture
1 participant
@carlaKC