Implement Debug/PartialEq/Eq for Destination

[TheBlueMatt]

No description provided.

[coderabbitai]

Walkthrough

This update primarily focuses on enhancing the OnionMessagePath struct within the messenger.rs file of the Lightning project. Specifically, the Destination enum now supports additional traits: Debug, PartialEq, and Eq, making it easier to debug, compare, and ensure equality checks, alongside its existing Clone capability.

Changes

File Path	Summary of Changes
lightning/src/onion_message/messenger.rs	Updated Destination enum in OnionMessagePath to derive Debug, PartialEq, and Eq traits.

🏈🐰💫
As the Chiefs and Niners clash in a spirited game,
On the field under the grand Super Bowl's name.
Here in code, we too celebrate a change,
Making paths clearer, within the Lightning's range.
Debug, compare, in harmony they align,
As fans cheer on, in the sunshine or the rain's whine.
🎉🏆🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between d70124c and 71c0d56.

Files selected for processing (1)

• lightning/src/onion_message/messenger.rs (1 hunks)

Additional comments: 1

lightning/src/onion_message/messenger.rs (1)

• 416-416: The Destination enum now correctly derives Debug, PartialEq, and Eq traits, aligning with the PR's objectives.

[codecov-commenter]

Codecov Report

Attention: 313 lines in your changes are missing coverage. Please review.

Comparison is base (3e4c15b) 89.33% compared to head (71c0d56) 89.10%.
Report is 16 commits behind head on main.

Files	Patch %	Lines
lightning/src/ln/msgs.rs	25.06%	202 Missing and 67 partials ⚠️
lightning/src/ln/channel.rs	87.58%	17 Missing and 1 partial ⚠️
lightning/src/ln/channelmanager.rs	70.45%	12 Missing and 1 partial ⚠️
lightning/src/ln/peer_handler.rs	0.00%	12 Missing ⚠️
lightning/src/onion_message/messenger.rs	0.00%	0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2888      +/-   ##
==========================================
- Coverage   89.33%   89.10%   -0.23%     
==========================================
  Files         115      115              
  Lines       93892    94105     +213     
  Branches    93892    94105     +213     
==========================================
- Hits        83875    83853      -22     
- Misses       7603     7772     +169     
- Partials     2414     2480      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[benthecarman]

Maybe add hash as well

[tnull]

LGTM

I'll go ahead and merge this as the change is trivial and we can do a follow-up if we want to add Hash afterall.