Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry InvoiceRequest messages #2836

Closed
jkczyz opened this issue Jan 17, 2024 · 0 comments · Fixed by #3010
Closed

Retry InvoiceRequest messages #2836

jkczyz opened this issue Jan 17, 2024 · 0 comments · Fixed by #3010

Comments

@jkczyz
Copy link
Contributor

jkczyz commented Jan 17, 2024

When using ChannelManager::pay_for_offer, we send an InvoiceRequest for each path in the Offer in parallel, paying the first Bolt12Invoice received in response and ignoring the rest. This is necessary because onion messages can be unreliable; we can't be sure a message was actually delivered. While this adds a degree of robustness to the offers flow, it is not enough. For instance, an Offer may only have one path so only one attempt would be made. Or ephemeral networking issues could result in all messages lost, etc.

Currently, OutboundPayments will fail any request that hasn't received a response after some StaleExpiration criteria. Before this is reached, we should attempt to retry the request as necessary. This should work across node restarts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant