Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store a cached NodeId for each of our Peers in PeerManager. #2021

Closed
TheBlueMatt opened this issue Feb 7, 2023 · 1 comment · Fixed by #2022
Closed

Store a cached NodeId for each of our Peers in PeerManager. #2021

TheBlueMatt opened this issue Feb 7, 2023 · 1 comment · Fixed by #2022
Labels
good first issue Good for newcomers

Comments

@TheBlueMatt
Copy link
Collaborator

See #2016 (comment)
@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label Feb 7, 2023
@alecchendev
Copy link
Contributor

I'm thinking the most intuitive way to do this might be to just add a field Option<NodeId> to Peer that gets stored whenever the Peer's their_node_id: Option<PublicKey> gets set? Another way might be to keep a HashMap<PublicKey, NodeId> in PeerManager.

@alecchendev alecchendev mentioned this issue Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store a cached NodeId for each Peer alecchendev/rust-lightning
2 participants
@TheBlueMatt @alecchendev