Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Accepting HTLCs with less value than the onion claims to pay #1999

Closed
3 tasks done
TheBlueMatt opened this issue Feb 1, 2023 · 3 comments · Fixed by #2715
Closed
3 tasks done

Allow Accepting HTLCs with less value than the onion claims to pay #1999

TheBlueMatt opened this issue Feb 1, 2023 · 3 comments · Fixed by #2715
Assignees
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

TheBlueMatt commented Feb 1, 2023

If so configured, an LSP may skim some funds off the top of an HTLC, but we really dont want them to mess with the onion. Thus, we need a way to override the amount the onion claims to pay so that we can accept an HTLC that has an onion that says it pays X, but only pays X-$(configured fee). I'm not exactly sure how best to let the user configure $(configured fee), but ignoring it entirely isn't super practical as we need some way to figure out if an MPP payment is complete or not.

TODOs:

@TheBlueMatt TheBlueMatt added this to the 0.0.115 milestone Feb 1, 2023
@TheBlueMatt
Copy link
Collaborator Author

Slipping to 116 :(

@TheBlueMatt TheBlueMatt modified the milestones: 0.0.115, 0.0.116 Apr 17, 2023
@valentinewallace
Copy link
Contributor

cc lightning/blips#25

@TheBlueMatt
Copy link
Collaborator Author

The main parts of this are done, we really just need to include the skimmed fee in PaymentClaimed now, which can wait till 117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants