Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1507 followups #1945

Closed
TheBlueMatt opened this issue Jan 10, 2023 · 1 comment · Fixed by #1966
Closed

1507 followups #1945

TheBlueMatt opened this issue Jan 10, 2023 · 1 comment · Fixed by #1966
Assignees
@ViktorTigerstrom
Milestone
0.0.114

Comments

@TheBlueMatt
Copy link
Collaborator

A bunch of trivial things, but also one memory leak that now needs fixed for 114 - #1507 (review)
@TheBlueMatt TheBlueMatt added this to the 0.0.114 milestone Jan 10, 2023
@TheBlueMatt TheBlueMatt mentioned this issue Jan 17, 2023
Merged
@TheBlueMatt
Copy link
Collaborator Author

Also, we should go through the cases where we set APIMisuseError for methods where we don't find the peer and make sure it shouldn't instead be ChannelUnavailable. #1939 (comment)

@ViktorTigerstrom ViktorTigerstrom mentioned this issue Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ViktorTigerstrom ViktorTigerstrom

Labels
None yet
Projects
None yet
Milestone
0.0.114
Development

Successfully merging a pull request may close this issue.

1507 followups ViktorTigerstrom/rust-lightning
2 participants
@TheBlueMatt @ViktorTigerstrom