Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow update_fee sending during shutdown negotiation #1590

Open
TheBlueMatt opened this issue Jul 2, 2022 · 1 comment
Open

Allow update_fee sending during shutdown negotiation #1590

TheBlueMatt opened this issue Jul 2, 2022 · 1 comment
Milestone
0.2

Comments

@TheBlueMatt
Copy link
Collaborator

Currently if we've started shutdown we refuse to queue up update_fee messages, but we absolutely should, given they can be important if shutdown takes a while due to a stuck HTLC. Further, we may actually have an edge case where we send an update_fee as the very last thing in a channel - if there's an update_fee pending in the holding cell (and its the only thing in the holding cell) when we receive our peer's last RAA we may let the update_fee fly even though there are no remaining HTLCs, violating the BOLTs (cc lightning/bolts#970).
@TheBlueMatt TheBlueMatt added this to the 0.1 milestone Jul 2, 2022
@TheBlueMatt
Copy link
Collaborator Author

Kicking the can in the hopes we delete update_fee instead.

@TheBlueMatt TheBlueMatt modified the milestones: 0.1, 0.1.1 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
1 participant
@TheBlueMatt