Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSPS1: Update message format and get client working #140

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

LSPS1: Update message format and get client working #140

wants to merge 11 commits into from

Commits on Jul 1, 2024

  1. Add (commented-out) path to local LDK packages 

    .. to make it easier to switch back-and-forth when testing.
    @tnull
    tnull committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    a11f2c4 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Drop cfg(lsps1) flag

    @tnull
    tnull committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    f65b378 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Disallow warnings for LSPS1

    @tnull
    tnull committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e57703c View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. LSPS0: Advertise supported protocols 

    We previously didn't advertise the supported protocols, even if the
corresponding service handlers were available.
    @tnull
    tnull committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    97d6150 View commit details
    Browse the repository at this point in the history

  2. Re-introduce feature gate for lsps1_service

    @tnull
    tnull committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6ce2675 View commit details
    Browse the repository at this point in the history

  3. Update message types to include payment options 

    .. as of LSPS#101.
    @tnull
    tnull committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d29d75f View commit details
    Browse the repository at this point in the history

  4. Make token optional

    @tnull
    tnull committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    649bcbc View commit details
    Browse the repository at this point in the history

  5. Drop spurious cfg flag

    @tnull
    tnull committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    4f4bcce View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. LSPS1: Simplify and align client logic 

    .. we tremendously simplify the client logic, also dropping any state
tracking for now (possibly to be re-added in the future).

We also get the LSPS1 API closer to LSPS2 and make sure the API/docs is
more consistent.
    @tnull
    tnull committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    564320e View commit details
    Browse the repository at this point in the history

  2. De-/Serialize addresses assuming their network isn't bogus 

    .. as we have no real way to check the network at the point of
deserialzation, and we want to handle `bitcoin::Addresses`, not uncheck
addresses, in particular when it comes to serialization.
    @tnull
    tnull committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    b014a08 View commit details
    Browse the repository at this point in the history

  3. Account for missing refund_onchain_address field 

    We allow de/serializing if the field is absent.
    @tnull
    tnull committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    ca3c923 View commit details
    Browse the repository at this point in the history