Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

1.6.0 not compatible with Lagom 1.4.10 #168

Closed
ignasi35 opened this issue Jan 9, 2019 · 1 comment
Closed

1.6.0 not compatible with Lagom 1.4.10 #168

ignasi35 opened this issue Jan 9, 2019 · 1 comment
Assignees

Comments

@ignasi35
Copy link
Contributor

ignasi35 commented Jan 9, 2019

After Play 2.6.20 the Play dependency to sbt-native-packager bumped to 1.3.15.

sbt-reactove-app uses sbt-native-packager by extending DockerKeys. DockerKeys in sbt-native-packager changed in the 1.3.x family (new fields added in 1.3.12 and 1.3.14).

Using sbt-reactive-app with Play 2.6.21 is not possible:

...
[warn] There may be incompatibilities among your library dependencies; run 'evicted' to see detailed eviction warnings.
[info] Loading settings for project lagom-minimal-deployment-sample from build.sbt ...
[error] java.lang.AbstractMethodError
[error]         at com.typesafe.sbt.packager.docker.DockerKeys.$init$(Keys.scala:25)
[error]         at com.lightbend.rp.sbtreactiveapp.SbtReactiveAppPlugin$localImport$.<init>(SbtReactiveAppPlugin.scala:95)
[error]         at com.lightbend.rp.sbtreactiveapp.SbtReactiveAppPlugin$localImport$.<clinit>(SbtReactiveAppPlugin.scala)
[error]         at com.lightbend.rp.sbtreactiveapp.DeployableApp.projectSettings(Deploy.scala:193)
[error]         at com.lightbend.rp.sbtreactiveapp.DeployableApp.projectSettings$(Deploy.scala:36)
[error]         at com.lightbend.rp.sbtreactiveapp.BasicApp$.projectSettings(App.scala:260)
[error]         at com.lightbend.rp.sbtreactiveapp.SbtReactiveAppPlugin$.projectSettings(SbtReactiveAppPlugin.scala:109)
[error]         at com.lightbend.rp.sbtreactiveapp.SbtReactiveAppPlugin$.projectSettings(SbtReactiveAppPlugin.scala:46)
[error]         at sbt.internal.Load$.$anonfun$resolveProject$3(Load.scala:1062)
[error]         at scala.collection.TraversableLike.$anonfun$flatMap$1(TraversableLike.scala:240)
[error]         at scala.collection.immutable.List.foreach(List.scala:388)
...

Both sbt-reactive-app 1.5.0 and 1.6.0 fail.

This is arguably a Play issue and not a sbt-reactive-app issue though.

@dwijnand
Copy link
Member

dwijnand commented Jan 9, 2019

There's no need to inherit DockerKeys, can just alias DockerPlugin.autoImport.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants