Replace travis with GitHub actions #28
Conversation
build.sbt
Outdated
| JavaSpec.temurin("17") | ||
| ) | ||
|
|
||
| ThisBuild / githubWorkflowTargetBranches := Seq("master") |
There was a problem hiding this comment.
maybe already
| ThisBuild / githubWorkflowTargetBranches := Seq("master") | |
| ThisBuild / githubWorkflowTargetBranches := Seq("main", "master") |
for if/when we move to that - not important though
There was a problem hiding this comment.
I can do this but its different to the other lightbend projects where I integrated sbt-paradox-dependencies so it would be inconsistent in this regard. Would you be happy if I made an issue stating that you also need to do ThisBuild / githubWorkflowTargetBranches when changing from main to master?
Also I think that @ennru is familiar with sbt-github-actions and is aware of this.
There was a problem hiding this comment.
I can do this but its different to the other lightbend projects where I integrated sbt-paradox-dependencies so it would be inconsistent in this regard.
Ok
Would you be happy if I made an issue stating that you also need to do
ThisBuild / githubWorkflowTargetBrancheswhen changing frommaintomaster?
I don't think an issue is strictly necessary, we'll notice soon enough when we make the switch :)
There was a problem hiding this comment.
Let's add main so that we can do the branch rename.
|
(we'd have to make sure those secrets are available to the github action, but I don't have the authorizations to do that in this repo) |
| addSbtPlugin("de.heikoseeberger" % "sbt-header" % "5.6.0") | ||
| addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.6") | ||
| addSbtPlugin("com.codecommit" % "sbt-github-actions" % "0.14.2") | ||
| addSbtPlugin("com.github.sbt" % "sbt-ci-release" % "1.5.10") |
There was a problem hiding this comment.
Doesn't this come in transitively with sbt-github-actions?
There was a problem hiding this comment.
If you mean sbt-ci-release, this is seperate to sbt-github-actions. sbt-ci-release provides
sbt-dynver: sets the version number based on your git history
sbt-pgp: to cryptographically sign the artifacts before publishing
sbt-sonatype: to publish artifacts to Sonatype
sbt-git: to automatically populate scmInfo
transitively (see https://github.com/sbt/sbt-ci-release#sbt)
| // don't do any API docs | ||
| doc / sources := Seq() | ||
| packageDoc / publishArtifact := false |
There was a problem hiding this comment.
We can continue to skip publishing of sources and Scaladoc.
There was a problem hiding this comment.
Didn't this break publishing to sonatype (i.e. the issues behind lightbend/sbt-paradox-project-info#32)?
build.sbt
Outdated
| JavaSpec.temurin("17") | ||
| ) | ||
|
|
||
| ThisBuild / githubWorkflowTargetBranches := Seq("master") |
There was a problem hiding this comment.
Let's add main so that we can do the branch rename.
|
I just pushed the changes to accept |
|
I added the secrets, but it didn't trigger releasing when I just created the release in the GH UI. Pushing the tag worked, though. |
This PR replaces travis with sbt-github-actions. Also handles publishing via sonatype.