Unpickle "privateWith", aka "package private" #583
Conversation
dwijnand
force-pushed
the
package-private
branch
from
2dc0540
to
edd26cb
Compare
|
which Scala versions does this work for? (2.11, 2.12, 2.13, 3?) |
|
2.11-2.13. There's no pickle for Scala 3 (the new pickle is tasty, yum). |
|
would "add TASTy support" be a good "help wanted" ticket on this, then? |
|
I think EPFL is testing the waters there, or maybe just have intent to (I think at the Scala Center but not sure). I'm not against it being another project - I'm not sure if if it's a better or worst thing if it's the same project. WDYT? |
dwijnand
force-pushed
the
package-private
branch
from
4f2e0a2
to
47acc51
Compare
|
I don't see any reason it would or should be a separate project, but perhaps I'm missing something. |
|
@sjrd am I aware correctly? Is someone actively or soon working on something in this area? |
|
We're working on a project that will eventually allow us to build TASTy-MiMa. But TASTy-MiMa is anyway going to be complementary to MiMa, not replacing it. It will check backward TASTy compatibility, but that does not imply (nor is implied by) backward binary compatibility, which MiMa tests for. |
core/src/main/scala/com/typesafe/tools/mima/core/ClassInfo.scala
Outdated
Show resolved
Hide resolved
dwijnand
force-pushed
the
package-private
branch
2 times, most recently
from
f2a0de6
to
bd602ba
Compare
Anything which is package private is now excluded from the problem analysis MiMa does. This includes: * classes/traits/objects, * methods/fields, * method overloads, * as well as classes becoming private/public. * case classes, or more generally class/object companions * nested classes/objects (tested up to 3 levels)
dwijnand
force-pushed
the
package-private
branch
from
bd602ba
to
8d93547
Compare
|
TODO: Make unpickling opt-out-able. |
|
Nvm. Making it opt-out-able is a PITA. |
Anything which is package private is now excluded from the problem
analysis MiMa does. This includes:
Fixes #53