Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Support multiple instances and extra labels for service monitor #171

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

ryan-dyer-sp
Copy link
Contributor

Fix for : #170

Add instance label in order to distinguish between one chart and another deployed into same namespace

@lightbend-cla-validator

Hi @ryan-dyer,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@seglo
Copy link
Owner

seglo commented Oct 19, 2020

@ryan-dyer LGTM, but the CLA needs to be signed before I can merge the PR.

@lightbend-cla-validator

Hi @ryan-dyer,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@ryan-dyer-sp
Copy link
Contributor Author

@seglo I've signed this like 3 times now. I'm told
"Thank you! Your submission was processed."

@seglo seglo closed this Oct 19, 2020
@seglo seglo reopened this Oct 19, 2020
@seglo
Copy link
Owner

seglo commented Oct 19, 2020

@ryan-dyer-sp It's probably because your commit identity doesn't match your GitHub id. If you sign with the other id, or rebase your commits with the signed id, then it should work. Might need to create a new PR though.

@ryan-dyer-sp
Copy link
Contributor Author

That was it. Thanks!

@seglo seglo closed this Oct 19, 2020
@seglo seglo reopened this Oct 19, 2020
@seglo seglo changed the title Issue 170 Support multiple instances and extra labels for service monitor Oct 19, 2020
@seglo seglo merged commit c58d967 into seglo:master Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants