Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Add Metadata poll timer metric #105

Merged
merged 2 commits into from
Jan 26, 2020
Merged

Conversation

anbarasantr
Copy link
Contributor

Fixes #46 and #49

@anbarasantr
Copy link
Contributor Author

@seglo I am not really sure how to write tests for this scenario. Do you have any suggestion ?

@seglo
Copy link
Owner

seglo commented Nov 25, 2019

Thanks a lot for working on this @anbarasantr. I took a quick look. The ideal way to test this would be to use the Akka typed testkit in ConsumerGroupCollectorSpec where the metric is reported. You may need to modify ConsumerGroupCollector to accept a custom java.time clock in order to control time correctly.

You could also add this to an existing or new integration test in IntegrationSpec by asserting that the metric exists and has some valid value.

@seglo seglo merged commit 5d0be44 into seglo:master Jan 26, 2020
@seglo seglo mentioned this pull request Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata poll timer metric
2 participants