Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect completion result when opening a function #167

Open
rhdunn opened this issue Dec 4, 2015 · 2 comments
Open

Incorrect completion result when opening a function #167

rhdunn opened this issue Dec 4, 2015 · 2 comments

Comments

@rhdunn
Copy link

rhdunn commented Dec 4, 2015

With the fix for #161, go to the Editor > General > Smart Keys settings, and disable the Insert pair bracket option.

Given:

declare function foo() <caret>

typing { gives:

declare function foo() {<caret>
;

With the Insert pair bracket option enabled, I am seeing the correct behaviour as per the test case for this.

Additionally, given:

declare function foo() <caret>
};

typing { gives:

declare function foo() {<caret>
;};

With the Insert pair bracket option enabled, I get:

declare function foo() {<caret>
};;
@rhdunn
Copy link
Author

rhdunn commented Dec 4, 2015

An additional case -- this does not autocomplete when typing on the last line of a file with Insert pair bracket. In that case, typing { does not add the semi-colon.

I would only expect this autocomplete action to be triggered when Insert pair bracket is true.

@ligasgr
Copy link
Owner

ligasgr commented Dec 7, 2015

Thanks for raising that. I'll try to improve handling of all of those edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants