Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden inputs inside the management toolbar's search form #876

Closed
4lejandrito opened this issue May 7, 2018 · 1 comment
Closed

Hidden inputs inside the management toolbar's search form #876

4lejandrito opened this issue May 7, 2018 · 1 comment

Comments

@4lejandrito
Copy link
Member

4lejandrito commented May 7, 2018

The way forms were implemented before management toolbar was:

  • Method: GET
  • A bunch of input[type="hidden"] with every parameter.

After applying the management toolbar:

  • Method: POST
  • All the parameters are included in the action URL.

Now that the method is GET again (which is correct) search is broken everywhere. This is because when a form is GET it will replace all the parameters in the action URL with the form inputs (see a nice explanation here).

Now search will hit a URL like this: http://localhost:8080/group/guest/~/control_panel/manage?_com_liferay_document_library_web_portlet_DLAdminPortlet_keywords=blabla which only contains the keywords parameter and none of the original ones which are needed.

We need a way to add hidden inputs to the search form.

Regards

@carloslancha
Copy link
Contributor

This will be added vía portal and #938

Closing this, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants