Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parameter types in clay-charts #644

Closed
julien opened this issue Feb 26, 2018 · 0 comments
Closed

Wrong parameter types in clay-charts #644

julien opened this issue Feb 26, 2018 · 0 comments
Assignees
Labels
status: next-release Issues that will enter into the next release

Comments

@julien
Copy link
Contributor

julien commented Feb 26, 2018

In CharBase the following state properties have wrong validators:

regions: Config.shapeOf({
  class: Config.string(),
  enabled: Config.oneOf(['x', 'y']).required(),
  end: Config.array().required(),
  start: Config.number().required(),
}),

But this should be

regions: Config.arrayOf(                // <-- an array of objects with this shape
  Config.shapeOf({
    class: Config.string(),
    enabled: Config.oneOf(['x', 'y']).required(),
    end: Config.number().required(),
    start: Config.number().required(),  // <-- number instead of array
  }),
),
@julien julien self-assigned this Feb 26, 2018
@carloslancha carloslancha added the status: next-release Issues that will enter into the next release label Feb 26, 2018
@jbalsas jbalsas closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: next-release Issues that will enter into the next release
Projects
None yet
Development

No branches or pull requests

3 participants