Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClayDropDown is not focusing correctly #2357

Closed
matuzalemsteles opened this issue Aug 30, 2019 · 1 comment · Fixed by #2369
Closed

ClayDropDown is not focusing correctly #2357

matuzalemsteles opened this issue Aug 30, 2019 · 1 comment · Fixed by #2369
Assignees
@matuzalemsteles
Labels
3.x comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: regression Issues that are open that caused some regression
Milestone
IFI-940 v3.0.0

Comments

@matuzalemsteles
Copy link
Member

When we deprecated ClayDropDownWithBasicItems to ClayDropDownWithItems, we didn't add FocusScope and useFocusManagement this causes a regression on all components that use.
@matuzalemsteles matuzalemsteles added comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: regression Issues that are open that caused some regression 3.x labels Aug 30, 2019
@matuzalemsteles matuzalemsteles self-assigned this Aug 30, 2019
@matuzalemsteles
Copy link
Member Author

cc @Masterfoni

@matuzalemsteles matuzalemsteles mentioned this issue Sep 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matuzalemsteles matuzalemsteles

Labels
3.x comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: regression Issues that are open that caused some regression
Projects
None yet
Milestone
IFI-940 v3.0.0
Development

Successfully merging a pull request may close this issue.

refactor: rewrite the useFocusManagement hook with a new approach matuzalemsteles/clay
1 participant
@matuzalemsteles