Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to get the AlloyEditor version inside a Liferay 7.1 instance? #951

Closed
caneta opened this issue Jan 14, 2019 · 7 comments
Closed

How to get the AlloyEditor version inside a Liferay 7.1 instance? #951

caneta opened this issue Jan 14, 2019 · 7 comments

Comments

@caneta
Copy link

caneta commented Jan 14, 2019

On a Liferay 7.1 installation, is there a way to get the AlloyEditor version installed?

JavaScript key AlloyEditor.version does not exist: any other methods to get it?

Thank you.

@julien
Copy link
Contributor

julien commented Jan 21, 2019

Hi @caneta,

As far as I know this is not available at the moment, but we could consider adding that.

Thanks for your suggestion

@jbalsas
Copy link
Contributor

jbalsas commented Jan 22, 2019

Hey @caneta, could you describe your end use case with a bit more of detail? I'm asking because AlloyEditor is not always present on a page, so there will be cases where not even AlloyEditor will be defined.

What are you trying to attempt? Where do you expect to be able to detect the included editor version?

@caneta
Copy link
Author

caneta commented Jan 22, 2019

When the global variable AlloyEditor is present in page, I would like to know at runtime which version I'm using.
Like for the AMD Loader or Senna.js the purpose is always the same: when I get into trouble with a component the first thought that comes into my mind is "Why this issue? Wait! But is this component updated to the latest version?"
And so I would like a simple way to get at runtime this information.

@jbalsas
Copy link
Contributor

jbalsas commented Jan 22, 2019

I was asking because both the AMD Loader and Senna are present at all times in the page, while AlloyEditor isn't.

We're currently outputting the version to the bundled file, so you could explore the alloy-editor-no-ckeditor.min.js file to see the file right there at the top in the meantime.

@caneta
Copy link
Author

caneta commented Jan 22, 2019

I was asking because both the AMD Loader and Senna are present at all times in the page, while AlloyEditor isn't.

Sure, but I don't mind: I will call AlloyEditor.version when available...

We're currently outputting the version to the bundled file, so you could explore the alloy-editor-no-ckeditor.min.js file to see the file right there at the top in the meantime.

Ok, but it's a little bit unconfortable than having a property inside a JS object.

@jbalsas
Copy link
Contributor

jbalsas commented Jan 22, 2019

Yeah, I was just mentioning so you'd know where to look until we implement it

@caneta
Copy link
Author

caneta commented Jan 22, 2019

Yeah, I was just mentioning so you'd know where to look until we implement it

Ok, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants