Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark inconsistency in notebook on profiling and optimizing #77

Open
declann opened this issue Aug 26, 2024 · 2 comments
Open

benchmark inconsistency in notebook on profiling and optimizing #77

declann opened this issue Aug 26, 2024 · 2 comments

Comments

@declann
Copy link
Contributor

declann commented Aug 26, 2024

A little inconsistency in the notebook on profiling and optimizing the savings model:

image

Table and text are inconsistent. There is still a significant performance improvement when I run now: but it's more like ~16% down to ~8% (with a fair amount of variance)

@fumitoh
Copy link
Member

fumitoh commented Aug 27, 2024

Thanks! Would you care to PR? (Updating the text and rerunning the whole thing.)

@declann
Copy link
Contributor Author

declann commented Aug 29, 2024

Can do soon! (when I get around to do some environment setup)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants