Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect comment in events fetching #535

Open
F4ever opened this issue Oct 10, 2024 · 0 comments
Open

Incorrect comment in events fetching #535

F4ever opened this issue Oct 10, 2024 · 0 comments

Comments

@F4ever
Copy link
Member

F4ever commented Oct 10, 2024

Comment illustration mismatches code
ref_slot_shift = to_blockstamp.ref_slot - to_blockstamp.slot_number 22 - 18 = 4
for_slots_without_missed_blocks = for_slots - ref_slot_shift 10 - 4 = 6
from_block = max(0, to_blockstamp.block_number - for_slots_without_missed_blocks) 13 - 6 = 7

from_block on illustration is 3 instead of 7

#495 (comment)
@F4ever F4ever mentioned this issue Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@F4ever