Merge pull request #158 from lidofinance/fix/encode-sealable-missing-…

…type Audit fix: Incorrect Encoding of Sealable Resume Proposal
lidofinance · Nov 6, 2024 · 9fecfff · 9fecfff
2 parents 071f033 + 17b5510
commit 9fecfff
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/contracts/committees/TiebreakerSubCommittee.sol b/contracts/committees/TiebreakerSubCommittee.sol
@@ -140,7 +140,7 @@ contract TiebreakerSubCommittee is HashConsensus, ProposalsList {
         returns (bytes memory data, bytes32 key, uint256 nonce)
     {
         nonce = ITiebreakerCoreCommittee(TIEBREAKER_CORE_COMMITTEE).getSealableResumeNonce(sealable);
-        data = abi.encode(sealable, nonce);
+        data = abi.encode(ProposalType.ResumeSealable, sealable, nonce);
         key = keccak256(data);
     }
 }
diff --git a/test/unit/committees/TiebreakerSubCommittee.t.sol b/test/unit/committees/TiebreakerSubCommittee.t.sol
@@ -180,7 +180,8 @@ contract TiebreakerSubCommitteeUnitTest is UnitTest {
         vm.prank(committeeMembers[2]);
         vm.expectRevert(
             abi.encodeWithSelector(
-                HashConsensus.HashIsNotScheduled.selector, keccak256(abi.encode(sealable, /*nonce */ 0))
+                HashConsensus.HashIsNotScheduled.selector,
+                keccak256(abi.encode(ProposalType.ResumeSealable, sealable, /*nonce */ 0))
             )
         );
         tiebreakerSubCommittee.executeSealableResume(sealable);