-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse pgn without moves #604
Conversation
Nice! As a later improvement we could allow bare FEN input also. I guess it makes sense too. |
This is already possible. |
@HaonRekcef hi haon, thanks for your merge request 3 quick questions
[Event "?"] I've noticed the above failed in the new app but would work in the old apps
Thanks |
Hi @ijm8710,
|
Hi @HaonRekcef
[Event "Online Game"] 1.d4 Nf6 2.Nf3 g6 3.c4 Bg7 4.e3 O-O 5.Be2 d6 6.O-O c5 7.d5 Na6 8.Nc3 Bg4 9.h3 Bxf3 10.Bxf3 Nc7 11.a3 Re8 12.b4 e5 13.bxc5 e4 14.Be2 dxc5 15.f3 a6 16.fxe4 Nxe4 17.Nxe4 Bxa1 18.Nxc5 Rb8 19.Bd2 Bb2 20.Qb3 Bg7 21.Nxb7 Qc8 22.Nd6 Rxb3 23.Nxc8 Rxc8 24.Bg4 Re8 25.Ba5 Na8 26.Rf3 Rexe3 27.Rxe3 Rxe3 28.Kf2 Rxa3 29.Bb4 Ra4 30.Bc5 Rxc4 31.Be3 Bd4 32.Bxd4 Rxd4 33.Bf3 Rf4 34.d6 Nb6 35.g3 Rxf3+ 36.Kxf3 a5 37.Ke4 a4 38.Kd3 Kf8 39.Kc3 Ke8 40.Kb4 Kd7 41.g4 Kxd6 42.h4 Ke5 43.h5 Kf4 44.hxg6 hxg6 45.g5 Kxg5 46.Ka3 Kf5 47.Kb2 g5 48.Kc2 g4 49.Kd1 a3 50.Ke2 a2 51.Kf1 a1=Q+ 52.Kg2 Qb2+ 53.Kf1 Qc1+ 54.Kg2 Qd2+ 55.Kg3 Qe1+ 56.Kh2 Qf2+ 57.Kh1 Qh4+ 58.Kg1 g3 59.Kg2 Kg4 60.Kf1 Qh2 61.Ke1 Qf2+ 62.Kd1 g2 63.Kc1 {0-1}
|
The user will now be able to import a PGN file even if it does not contain any moves. This functionality is already present in the old app and on the website. For instance:
This position can now be analysed. One advantage of this over plain FEN is that PGN headers can also be imported.
I let the previous behaviour unchanged: If moves are present, at least the first move must be legal for the PGN analysable.
If there are no moves, there has to be a FEN header for it to be analysable.