You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make all functions not documented actually private by following the _function_name convention.
While this won't change any behavior or fix any problems, it will follow convention a bit better and reduce some of the exceptions in dist.ini for POD checks.
The text was updated successfully, but these errors were encountered:
Before making this change, we should check with grep.cpan.me that no other distributions are relying on the existing names (and get those fixed first).
It might be a good idea at any rate to add sub aliases with the old names, and a deprecation warning, e.g.:
sub function_name
{
warnings::warnif('deprecated', 'function_name is intended to be internal only and its use outside this module is not supported');
goto &_function_name;
}
As part of this month's (and last!) PRC, I started taking a look at this issue. I checked some of the easier methods, and added deprecation warnings to os_path, fix_path, nss, and nid. These are the ones I found no uses for, with the exception of nss, which is used by URI::db.
Not sure if this is worth a pull request, but it does look like a little progress, so I thought I'd point it out.
Make all functions not documented actually private by following the
_function_name
convention.While this won't change any behavior or fix any problems, it will follow convention a bit better and reduce some of the exceptions in
dist.ini
for POD checks.The text was updated successfully, but these errors were encountered: