Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAIL: test/run-tests #2549

Closed
jacob008 opened this issue Nov 23, 2019 · 6 comments · Fixed by sthagen/libuv-libuv#25
Closed

FAIL: test/run-tests #2549

jacob008 opened this issue Nov 23, 2019 · 6 comments · Fixed by sthagen/libuv-libuv#25

Comments

@jacob008
Copy link

ok 373 - we_get_signals
ok 374 - we_get_signals_mixed
FAIL: test/run-tests

1 of 1 test failed
Please report to https://github.com/libuv/libuv/issues

make[1]: *** [check-TESTS] Error 1
make[1]: Leaving directory `/root/c++/libuv/libuv'
make: *** [check-am] Error 2
[root@localhost libuv]#

我也不知道是干什么,它叫我report 到这里 ,我也不知道有什么用!

@jacob008
Copy link
Author

ok 47 - fs_chown
not ok 48 - fs_copyfile

exit code 6

Output from process fs_copyfile:

Assertion failed in test/test-fs-copyfile.c on line 202: req.result == UV_EACCES

ok 49 - fs_event_close_in_callback

补充一下。。

@sffc
Copy link

sffc commented Dec 23, 2019

+1, this is reproducible on CentOS 7 with unmodified code built with autotools from the v1.x branch:

...
ok 46 - fs_chmod
ok 47 - fs_chown
not ok 48 - fs_copyfile
# exit code 134
# Output from process `fs_copyfile`:
# Assertion failed in test/test-fs-copyfile.c on line 202: req.result == UV_EACCES
ok 49 - fs_event_close_in_callback
ok 50 - fs_event_close_with_pending_event
...

@sffc
Copy link

sffc commented Dec 23, 2019

The test failure reproduces on v1.32.0 but not v1.24.1. I didn't check all the versions between v1.24.1 and v1.32.0.

@cjihrig
Copy link
Contributor

cjihrig commented Dec 23, 2019

Are you able to provide the value of req.result here? That test was added in c7b87b0, when it was discovered that macOS wasn't respecting file permissions in its copyfile() function. Hopefully you're just bumping into a different error code.

@richardlau
Copy link
Contributor

make[1]: Leaving directory `/root/c++/libuv/libuv'

I think test failures are expected if running as root?

@cjihrig
Copy link
Contributor

cjihrig commented Dec 23, 2019

I think test failures are expected if running as root?

Yes, that too. The issue template explicitly calls that out, and has since before this issue was created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants