Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mistake in name #683

Closed
nitrologic opened this issue Aug 1, 2024 · 3 comments
Closed

mistake in name #683

nitrologic opened this issue Aug 1, 2024 · 3 comments
Labels
macOS Related to macOS backend

Comments

@nitrologic
Copy link

https://github.com/libusb/hidapi/blame/4578ea24613af03e5631e400ed1167462702a112/mac/hid.c#L1344

I think this method should be

hid_send_output_report

not

hid_send_output_feature_report

to match the public decl in hidapi.h[480]

@mbcinergy
Copy link
Contributor

You are correct, that must have been a copy/paste error.

Strange that the macos build pipeline does not error on this.

@Youw Youw closed this as completed in d101e5c Aug 2, 2024
@Youw
Copy link
Member

Youw commented Aug 2, 2024

OK, I was planning on making a PR instead of pushing d101e5c directly into master...

But since I didn't break anything (and, apparently fixed an issue) I will consider this time as an exception, and will add a protection rule to master branch to avoid such in the future.

@Youw
Copy link
Member

Youw commented Aug 2, 2024

Strange that the macos build pipeline does not error on this.

And, apparently, no one is using it yet.

@mcuee mcuee added the macOS Related to macOS backend label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macOS Related to macOS backend
Projects
None yet
Development

No branches or pull requests

4 participants