Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library install_name is wrong on macOS #194

Closed
jmroot opened this issue Aug 27, 2022 · 2 comments
Closed

Library install_name is wrong on macOS #194

jmroot opened this issue Aug 27, 2022 · 2 comments
Assignees
Milestone

Comments

@jmroot
Copy link
Contributor

jmroot commented Aug 27, 2022

The install_name is set to just libSDL-1.2.0.dylib (should be either the full installation path, or relative to @something.) Removing this line from CMakeLists.txt seems to fix it:

set_target_properties(SDL PROPERTIES INSTALL_NAME_DIR "")

Not quite sure why that is being done in the first place, but maybe there's a good reason?

@icculus icculus self-assigned this Aug 29, 2022
@icculus
Copy link
Collaborator

icculus commented Aug 29, 2022

Not quite sure why that is being done in the first place, but maybe there's a good reason?

There might be, but I can't remember what at this point. I'll look into why (and possibly just remove the line).

@icculus icculus added this to the 1.2.54 milestone Aug 29, 2022
@icculus
Copy link
Collaborator

icculus commented Sep 1, 2022

Apparently I added this to shut off a cmake warning in 8743305, and @sezero noted it didn't help, so I'll just back it out.

@icculus icculus closed this as completed in 5642d47 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants