Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SDL_MUTEX_MAXWAIT? #8436

Closed
icculus opened this issue Oct 25, 2023 · 1 comment
Closed

Rename SDL_MUTEX_MAXWAIT? #8436

icculus opened this issue Oct 25, 2023 · 1 comment
Assignees
Milestone

Comments

@icculus
Copy link
Collaborator

icculus commented Oct 25, 2023

/**
 *  This is the timeout value which corresponds to never time out.
 */
#define SDL_MUTEX_MAXWAIT   -1

We should rename this something like SDL_MUTEX_FOREVER or SDL_MUTEX_NOTIMEOUT so it doesn't sound like one can outwait the thing if some timer maximum rolls over (which a positive Sint32 will do in ~24 days).

(Or just remove it and say "pass a -1 to wait forever"? to these functions?)

@icculus icculus added this to the 3.2.0 milestone Oct 25, 2023
@slouken
Copy link
Collaborator

slouken commented Oct 25, 2023

It's not just used by mutexes, so I'm fine with either renaming it or removing it.

@icculus icculus self-assigned this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants