-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using libsamplerate with CMake on Windows #5809
Comments
All binary releases of the next SDL2 release will ship with a CMake script that allows the following use: find_package(SDL2 REQUIRED)
add_executable(mygame mysource.c)
target_link_libraries(mygame PRIVATE SDL2::SDL2) |
libsamplerate is only checked in Linux Line 1307 in a5949d7
this should be Line 54 in a5949d7
it would be better to use find_package directly - it looks like it is used eventually, but now you need to first pass the include directory to look for it somehow in the command line before it's added through it's own cmake config module. Line 372 in a5949d7
It would be perfect if it had the dynamic api to look for I also need this to workaround #5538 |
Hey thanks! This worked for me! I ended up adding an additional |
I tested it by adding |
Libsamplerate provides binary releases for Windows and even include a cmake script, it would be nice if it was possible to use it on Windows too!
The text was updated successfully, but these errors were encountered: