Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename hidapi symbols to prevent static linking issues #4602

Closed
Yamakaky opened this issue Aug 6, 2021 · 2 comments
Closed

Rename hidapi symbols to prevent static linking issues #4602

Yamakaky opened this issue Aug 6, 2021 · 2 comments
Assignees
Milestone

Comments

@Yamakaky
Copy link

Yamakaky commented Aug 6, 2021

SDL bundles a modified version of hidapi. Doing a static link of both upstream hidapi and SDL will override the modified functions, causing all sort of problems. To prevent this, every function in the bundled version should be prefixed to prevent conflicts, for example with SDL_.

See #4596 for a real world example.

@slouken
Copy link
Collaborator

slouken commented Nov 7, 2021

We need to make sure we don't do this on Android, since the Java code interacts with just one C++ side implementation.

@slouken slouken added this to the 2.0.18 milestone Nov 7, 2021
@slouken
Copy link
Collaborator

slouken commented Nov 8, 2021

This is implemented in 5b646cd.

@slouken slouken closed this as completed Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants