From 8c6ca0adc8fb50b43be71943f7d26d99d5986023 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Fri, 14 Jun 2024 11:14:38 +0200 Subject: [PATCH 01/24] Rename github workflow file --- .github/workflows/{lxl-web-tests.yml => lxl-web.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{lxl-web-tests.yml => lxl-web.yml} (100%) diff --git a/.github/workflows/lxl-web-tests.yml b/.github/workflows/lxl-web.yml similarity index 100% rename from .github/workflows/lxl-web-tests.yml rename to .github/workflows/lxl-web.yml From 6734687aaa0901c7244aedbf18c2984c7b55b28a Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Fri, 14 Jun 2024 11:18:33 +0200 Subject: [PATCH 02/24] Format workflow file --- .github/workflows/lxl-web.yml | 52 +++++++++++++++++------------------ 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index 40d347822..e6770f38c 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -1,9 +1,9 @@ name: lxl-web on: push: - branches: [ develop ] + branches: [develop] pull_request: - branches: [ develop ] + branches: [develop] jobs: test: timeout-minutes: 60 @@ -12,27 +12,27 @@ jobs: run: working-directory: ./lxl-web steps: - - uses: actions/checkout@v4 - - uses: actions/setup-node@v4 - with: - node-version: 18 - - name: Setup yarn - run: npm install -g yarn - - name: Install lxljs dependency - run: yarn install --frozen-lockfile - working-directory: ./lxljs - - name: Install dependencies - run: npm ci - - name: Install Playwright Browsers - run: npx playwright install --with-deps - - name: Run Playwright tests - env: - API_URL: ${{ secrets.API_URL }} - ID_URL: ${{ secrets.ID_URL }} - run: npm run test - - uses: actions/upload-artifact@v4 - if: ${{ !cancelled() }} - with: - name: playwright-report - path: playwright-report/ - retention-days: 30 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 + with: + node-version: 18 + - name: Setup yarn + run: npm install -g yarn + - name: Install lxljs dependency + run: yarn install --frozen-lockfile + working-directory: ./lxljs + - name: Install dependencies + run: npm ci + - name: Install Playwright Browsers + run: npx playwright install --with-deps + - name: Run Playwright tests + env: + API_URL: ${{ secrets.API_URL }} + ID_URL: ${{ secrets.ID_URL }} + run: npm run test + - uses: actions/upload-artifact@v4 + if: ${{ !cancelled() }} + with: + name: playwright-report + path: playwright-report/ + retention-days: 30 From f6b47ccc887a0e1dea0149dd503f8c8e7e8e1aa5 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Fri, 14 Jun 2024 11:38:30 +0200 Subject: [PATCH 03/24] Add lighthouseci to github workflow --- .github/workflows/lxl-web.yml | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index e6770f38c..0a45fda63 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -36,3 +36,29 @@ jobs: name: playwright-report path: playwright-report/ retention-days: 30 + lighthouseci: + runs-on: ubuntu-latest + defaults: + run: + working-directory: ./lxl-web + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 + with: + node-version: 18 + - name: Setup yarn + run: npm install -g yarn + - name: Install lxljs dependency + run: yarn install --frozen-lockfile + working-directory: ./lxlj s + - name: Install dependencies + run: npm ci + - name: Build + env: + API_URL: ${{ secrets.API_URL }} + ID_URL: ${{ secrets.ID_URL }} + run: npm run build + - name: run Lighthouse CI + run: | + npm install -g @lhci/cli@0.13.x + lhci autorun From 4a05e1140226dc6f1fa3e788b16fc7e1f5f5af37 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Fri, 14 Jun 2024 11:42:06 +0200 Subject: [PATCH 04/24] Fix typo --- .github/workflows/lxl-web.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index 0a45fda63..c2f08d15a 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -50,7 +50,7 @@ jobs: run: npm install -g yarn - name: Install lxljs dependency run: yarn install --frozen-lockfile - working-directory: ./lxlj s + working-directory: ./lxljs - name: Install dependencies run: npm ci - name: Build From fcf66541d1995faeb75be2d5d1a98c4bfd45f6c6 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Fri, 14 Jun 2024 11:53:04 +0200 Subject: [PATCH 05/24] Add lighthouse config file --- lxl-web/lighthouserc.js | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 lxl-web/lighthouserc.js diff --git a/lxl-web/lighthouserc.js b/lxl-web/lighthouserc.js new file mode 100644 index 000000000..b82d7e642 --- /dev/null +++ b/lxl-web/lighthouserc.js @@ -0,0 +1,22 @@ +module.exports = { + ci: { + collect: { + url: 'http://localhost:4137/', + startServerCommand: 'npm run preview' + }, + assert: { + // assert options here + }, + upload: { + target: 'filesystem', + outputDir: './build/_lighthouse', + reportFilenamePattern: '%%PATHNAME%%.report.%%EXTENSION%%' + }, + server: { + // server options here + }, + wizard: { + // wizard options here + } + } +}; From 4456481f8af0686cb8726f99c5511894c208d3bf Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Fri, 14 Jun 2024 11:55:44 +0200 Subject: [PATCH 06/24] remake lighthouse config file to esm --- lxl-web/lighthouserc.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lxl-web/lighthouserc.js b/lxl-web/lighthouserc.js index b82d7e642..32918df1a 100644 --- a/lxl-web/lighthouserc.js +++ b/lxl-web/lighthouserc.js @@ -1,4 +1,4 @@ -module.exports = { +export default { ci: { collect: { url: 'http://localhost:4137/', From bba021f572f91d7473fc83e6fa713753790dc75f Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Fri, 14 Jun 2024 12:59:16 +0200 Subject: [PATCH 07/24] Use lighthouse-ci-action --- .github/workflows/lxl-web.yml | 14 ++++++++++---- lxl-web/lighthouserc.js | 22 ---------------------- 2 files changed, 10 insertions(+), 26 deletions(-) delete mode 100644 lxl-web/lighthouserc.js diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index c2f08d15a..b578048db 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -58,7 +58,13 @@ jobs: API_URL: ${{ secrets.API_URL }} ID_URL: ${{ secrets.ID_URL }} run: npm run build - - name: run Lighthouse CI - run: | - npm install -g @lhci/cli@0.13.x - lhci autorun + - name: Lighthouse CI Action + uses: treosh/lighthouse-ci-action@11.4.0 + with: + urls: | + https://localhost:4173 + http://localhost:4173/find?_q=*&_limit=10&_offset=0&_sort=&_i=* + https://localhost:4173/h08ndxddfg5v2pjf + # budgetPath: ./budget.json # test performance budgets + uploadArtifacts: true # save results as an action artifacts + temporaryPublicStorage: false # upload lighthouse report to the temporary storage \ No newline at end of file diff --git a/lxl-web/lighthouserc.js b/lxl-web/lighthouserc.js deleted file mode 100644 index 32918df1a..000000000 --- a/lxl-web/lighthouserc.js +++ /dev/null @@ -1,22 +0,0 @@ -export default { - ci: { - collect: { - url: 'http://localhost:4137/', - startServerCommand: 'npm run preview' - }, - assert: { - // assert options here - }, - upload: { - target: 'filesystem', - outputDir: './build/_lighthouse', - reportFilenamePattern: '%%PATHNAME%%.report.%%EXTENSION%%' - }, - server: { - // server options here - }, - wizard: { - // wizard options here - } - } -}; From 5ba09a52b0fe766ed7b2143d5d5582287caf0523 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Fri, 14 Jun 2024 13:07:54 +0200 Subject: [PATCH 08/24] Fix urls --- .github/workflows/lxl-web.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index b578048db..ab32dd329 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -62,9 +62,9 @@ jobs: uses: treosh/lighthouse-ci-action@11.4.0 with: urls: | - https://localhost:4173 + http://localhost:4173 http://localhost:4173/find?_q=*&_limit=10&_offset=0&_sort=&_i=* - https://localhost:4173/h08ndxddfg5v2pjf + http://localhost:4173/h08ndxddfg5v2pjf # budgetPath: ./budget.json # test performance budgets uploadArtifacts: true # save results as an action artifacts temporaryPublicStorage: false # upload lighthouse report to the temporary storage \ No newline at end of file From 411fb3758f6974e4e261663e3d46f6c1b9311685 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Fri, 14 Jun 2024 13:20:20 +0200 Subject: [PATCH 09/24] Build and preview before running lighthouse ci action --- .github/workflows/lxl-web.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index ab32dd329..2ba719f94 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -53,12 +53,12 @@ jobs: working-directory: ./lxljs - name: Install dependencies run: npm ci - - name: Build + - name: Build and preview env: API_URL: ${{ secrets.API_URL }} ID_URL: ${{ secrets.ID_URL }} - run: npm run build - - name: Lighthouse CI Action + run: npm run build && npm run preview + - name: Lighthouse CI Action uses: treosh/lighthouse-ci-action@11.4.0 with: urls: | @@ -67,4 +67,4 @@ jobs: http://localhost:4173/h08ndxddfg5v2pjf # budgetPath: ./budget.json # test performance budgets uploadArtifacts: true # save results as an action artifacts - temporaryPublicStorage: false # upload lighthouse report to the temporary storage \ No newline at end of file + temporaryPublicStorage: false # upload lighthouse report to the temporary storage From eb8744eb6f044dcc1b7a06826e43830eb4f95252 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Fri, 14 Jun 2024 13:27:53 +0200 Subject: [PATCH 10/24] Remove preview command again --- .github/workflows/lxl-web.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index 2ba719f94..c744045ba 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -53,11 +53,11 @@ jobs: working-directory: ./lxljs - name: Install dependencies run: npm ci - - name: Build and preview + - name: Build env: API_URL: ${{ secrets.API_URL }} ID_URL: ${{ secrets.ID_URL }} - run: npm run build && npm run preview + run: npm run build - name: Lighthouse CI Action uses: treosh/lighthouse-ci-action@11.4.0 with: From 7100958ef62487582a54c22106d52ef242a26880 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Mon, 17 Jun 2024 12:23:44 +0200 Subject: [PATCH 11/24] Revert to @lhci/cli --- .github/workflows/lxl-web.yml | 14 ++++---------- lxl-web/lighthouserc.json | 15 +++++++++++++++ 2 files changed, 19 insertions(+), 10 deletions(-) create mode 100644 lxl-web/lighthouserc.json diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index c744045ba..581b613e2 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -58,13 +58,7 @@ jobs: API_URL: ${{ secrets.API_URL }} ID_URL: ${{ secrets.ID_URL }} run: npm run build - - name: Lighthouse CI Action - uses: treosh/lighthouse-ci-action@11.4.0 - with: - urls: | - http://localhost:4173 - http://localhost:4173/find?_q=*&_limit=10&_offset=0&_sort=&_i=* - http://localhost:4173/h08ndxddfg5v2pjf - # budgetPath: ./budget.json # test performance budgets - uploadArtifacts: true # save results as an action artifacts - temporaryPublicStorage: false # upload lighthouse report to the temporary storage + - name: Run Lighthouse CI + run: | + npm install -g @lhci/cli@0.3.x + lhci autorun diff --git a/lxl-web/lighthouserc.json b/lxl-web/lighthouserc.json new file mode 100644 index 000000000..5e7cd3f61 --- /dev/null +++ b/lxl-web/lighthouserc.json @@ -0,0 +1,15 @@ +{ + "ci": { + "collect": { + "startServerCommand": "npm run preview", + "url": [ + "http://localhost:4173/", + "http://localhost:4173/find?_q=*&_limit=10&_offset=0&_sort=&_i=*", + "http://localhost:4173/h08ndxddfg5v2pjf" + ] + }, + "assert": { + "preset": "lighthouse:recommended" + } + } +} From 623517e417752eca1c9122d80769a44aa3b740b6 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Mon, 17 Jun 2024 12:30:46 +0200 Subject: [PATCH 12/24] Merge branch 'develop' into feature/LWS-159-run-lighthouse-tests-on-ci --- .github/workflows/lxl-web.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index 581b613e2..04c2470be 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -45,7 +45,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20 - name: Setup yarn run: npm install -g yarn - name: Install lxljs dependency From 57a988c2990ec77fcee21ddc6a53e182bbb456f3 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Mon, 17 Jun 2024 12:37:35 +0200 Subject: [PATCH 13/24] Update node version --- .github/workflows/lxl-web.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index 04c2470be..e96e0c732 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -15,7 +15,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20 - name: Setup yarn run: npm install -g yarn - name: Install lxljs dependency From d354cd25b88d39014dbefa2ae36fd4e9f3f3b9f7 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Tue, 18 Jun 2024 09:33:26 +0200 Subject: [PATCH 14/24] Use no-pwa preset and show warnings instead of errors --- lxl-web/lighthouserc.json | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/lxl-web/lighthouserc.json b/lxl-web/lighthouserc.json index 5e7cd3f61..122df550c 100644 --- a/lxl-web/lighthouserc.json +++ b/lxl-web/lighthouserc.json @@ -9,7 +9,21 @@ ] }, "assert": { - "preset": "lighthouse:recommended" + "preset": "lighthouse:no-pwa", + "assertions": { + "unsized-images": ["warn", { "minScore": 0.9 }], + "unused-javascript": ["warn", { "maxLength": 1 }], + "csp-xss": ["warn", { "minScore": 0.9 }], + "font-display": ["warn", { "minScore": 0.9 }], + "meta-description": ["warn", { "minScore": 0.9 }], + "tap-targets": ["warn", { "minScore": 0.9 }], + "target-size": ["warn", { "minScore": 0.0 }], + "total-byte-weight": ["warn", { "minScore": 0.9 }], + "empty-heading": ["warn", { "minScore": 0.9 }], + "label-content-name-mismatch": ["warn", { "minScore": 0.9 }], + "link-name": ["warn", { "minScore": 0.9 }], + "valid-source-maps": ["warn", { "minScore": 0.9 }] + } } } } From 610b2034fc7b76006a4c14ea18afb404f731cece Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Tue, 18 Jun 2024 09:33:55 +0200 Subject: [PATCH 15/24] Try fixing github action status --- .github/workflows/lxl-web.yml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index e96e0c732..b2d48f7db 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -42,7 +42,9 @@ jobs: run: working-directory: ./lxl-web steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v3 + with: + ref: ${{ github.event.pull_request.head.sha }} - uses: actions/setup-node@v4 with: node-version: 20 @@ -53,12 +55,11 @@ jobs: working-directory: ./lxljs - name: Install dependencies run: npm ci - - name: Build + - name: Build and run Lighthouse CI env: API_URL: ${{ secrets.API_URL }} ID_URL: ${{ secrets.ID_URL }} - run: npm run build - - name: Run Lighthouse CI run: | - npm install -g @lhci/cli@0.3.x - lhci autorun + npm run build + npm install -g @lhci/cli@0.13.x + lhci autorun \ No newline at end of file From 7d9124a238c2f83bd6b1b23dcbfa7f9dd056dbf7 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Tue, 18 Jun 2024 09:37:25 +0200 Subject: [PATCH 16/24] Add LHCI_GITHUB_APP_TOKEN --- .github/workflows/lxl-web.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index b2d48f7db..541205b17 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -59,6 +59,7 @@ jobs: env: API_URL: ${{ secrets.API_URL }} ID_URL: ${{ secrets.ID_URL }} + LHCI_GITHUB_APP_TOKEN: ${{ secrets.LHCI_GITHUB_APP_TOKEN }} run: | npm run build npm install -g @lhci/cli@0.13.x From ebf35aa170bf6bb6dd431dae6d800b05d15b4903 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Tue, 18 Jun 2024 09:53:52 +0200 Subject: [PATCH 17/24] Use actions/checkout@v4 --- .github/workflows/lxl-web.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index 541205b17..d5db02aae 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -42,7 +42,7 @@ jobs: run: working-directory: ./lxl-web steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: ref: ${{ github.event.pull_request.head.sha }} - uses: actions/setup-node@v4 From e8550b1b190b28739af8f2dbcecfb439f2063103 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Tue, 18 Jun 2024 10:01:52 +0200 Subject: [PATCH 18/24] Add startServerReadyPattern --- lxl-web/lighthouserc.json | 1 + 1 file changed, 1 insertion(+) diff --git a/lxl-web/lighthouserc.json b/lxl-web/lighthouserc.json index 122df550c..3a819a680 100644 --- a/lxl-web/lighthouserc.json +++ b/lxl-web/lighthouserc.json @@ -2,6 +2,7 @@ "ci": { "collect": { "startServerCommand": "npm run preview", + "startServerReadyPattern": "➜ Local:", "url": [ "http://localhost:4173/", "http://localhost:4173/find?_q=*&_limit=10&_offset=0&_sort=&_i=*", From ca7906ace38758ffd6c246b42b7903f874b528c8 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Tue, 18 Jun 2024 10:25:40 +0200 Subject: [PATCH 19/24] Update startServerReadyPattern --- lxl-web/lighthouserc.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lxl-web/lighthouserc.json b/lxl-web/lighthouserc.json index 3a819a680..3059ed995 100644 --- a/lxl-web/lighthouserc.json +++ b/lxl-web/lighthouserc.json @@ -2,7 +2,7 @@ "ci": { "collect": { "startServerCommand": "npm run preview", - "startServerReadyPattern": "➜ Local:", + "startServerReadyPattern": "Local:", "url": [ "http://localhost:4173/", "http://localhost:4173/find?_q=*&_limit=10&_offset=0&_sort=&_i=*", From 121e46f89a74bd24b2194ed72e31609458f202e9 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Tue, 18 Jun 2024 10:31:53 +0200 Subject: [PATCH 20/24] Update startServerReadyPattern yet again --- lxl-web/lighthouserc.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lxl-web/lighthouserc.json b/lxl-web/lighthouserc.json index 3059ed995..7752da992 100644 --- a/lxl-web/lighthouserc.json +++ b/lxl-web/lighthouserc.json @@ -2,7 +2,7 @@ "ci": { "collect": { "startServerCommand": "npm run preview", - "startServerReadyPattern": "Local:", + "startServerReadyPattern": " ➜ Local:", "url": [ "http://localhost:4173/", "http://localhost:4173/find?_q=*&_limit=10&_offset=0&_sort=&_i=*", From 3e72b7c6bf3b2f5af21d76e7564199ec8c9ab89c Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Tue, 18 Jun 2024 10:48:17 +0200 Subject: [PATCH 21/24] Add githubToken to lhci autorun --- .github/workflows/lxl-web.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index d5db02aae..dbe436456 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -63,4 +63,4 @@ jobs: run: | npm run build npm install -g @lhci/cli@0.13.x - lhci autorun \ No newline at end of file + lhci autorun --upload.githubToken="$LHCI_GITHUB_TOKEN" || echo "LHCI failed! \ No newline at end of file From a819455eb2335bdb3fa1d2256c495f05501fefa9 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Tue, 18 Jun 2024 10:50:16 +0200 Subject: [PATCH 22/24] Formatting --- .github/workflows/lxl-web.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index dbe436456..77b08eebf 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -63,4 +63,4 @@ jobs: run: | npm run build npm install -g @lhci/cli@0.13.x - lhci autorun --upload.githubToken="$LHCI_GITHUB_TOKEN" || echo "LHCI failed! \ No newline at end of file + lhci autorun --upload.githubToken="$LHCI_GITHUB_TOKEN" || echo "LHCI failed! From 0b53cc9cb6987b7ae4f4e246bdc2bd073c7394b7 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Tue, 18 Jun 2024 10:53:43 +0200 Subject: [PATCH 23/24] add missing character --- .github/workflows/lxl-web.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lxl-web.yml b/.github/workflows/lxl-web.yml index 77b08eebf..c01489be1 100644 --- a/.github/workflows/lxl-web.yml +++ b/.github/workflows/lxl-web.yml @@ -63,4 +63,4 @@ jobs: run: | npm run build npm install -g @lhci/cli@0.13.x - lhci autorun --upload.githubToken="$LHCI_GITHUB_TOKEN" || echo "LHCI failed! + lhci autorun --upload.githubToken="$LHCI_GITHUB_TOKEN" || echo "LHCI failed!" From 5e5a01214edef81e3bba26f692aae6525bae24d1 Mon Sep 17 00:00:00 2001 From: Johan Bisse Mattsson Date: Tue, 18 Jun 2024 11:22:30 +0200 Subject: [PATCH 24/24] Remove faulty startServerReadyPattern --- lxl-web/lighthouserc.json | 1 - 1 file changed, 1 deletion(-) diff --git a/lxl-web/lighthouserc.json b/lxl-web/lighthouserc.json index 7752da992..122df550c 100644 --- a/lxl-web/lighthouserc.json +++ b/lxl-web/lighthouserc.json @@ -2,7 +2,6 @@ "ci": { "collect": { "startServerCommand": "npm run preview", - "startServerReadyPattern": " ➜ Local:", "url": [ "http://localhost:4173/", "http://localhost:4173/find?_q=*&_limit=10&_offset=0&_sort=&_i=*",