Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No PAL option/support? #52

Open
maddin1502 opened this issue May 8, 2018 · 2 comments
Open

No PAL option/support? #52

maddin1502 opened this issue May 8, 2018 · 2 comments

Comments

@maddin1502
Copy link

maddin1502 commented May 8, 2018

I can't run PAL roms with correct speed, there is no region option available. Or am I wrong?

I adjusted some code and tried to get PAL working:
`unsigned retro_get_region(void)

  1. /libretro/libretro.cpp (no recognized effect)
    unsigned retro_get_region(void)
    {
    #return RETRO_REGION_NTSC;
    return RETRO_REGION_PAL;
    }

  2. /nes_emu/Nes_Emu.h (video speed is correct with this setting)
    // Number of frames generated per second
    #enum { frame_rate = 60 };
    enum { frame_rate = 50 };

  3. /nes_emu/Nes_Apu.cpp (no recognized effect)
    Nes_Apu::Nes_Apu() :
    square1( &square_synth ),
    square2( &square_synth )
    {
    ...

    #reset( false);
    reset( true );
    }

Option 2 resolves video speed. But now the sound is wrong.... speed is OK, pitch is too low
How can I do it right?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@maddin1502 maddin1502 changed the title No PAL support? No PAL option/support? May 8, 2018
@ghost
Copy link

ghost commented May 8, 2018

maybe use other full (or fuller) featured NES cores, unless you are suggesting you want to work on adding missing stuff...

@maddin1502
Copy link
Author

maddin1502 commented May 8, 2018

it is not really missing. fps are hardcoded, so changing 60 to 50 works well for video. I don't know how to solve the sound/pitch problem. there are some calculation done in code for sound but i can't find the right one or I just can not understand these. it's too complex without deeper knowledge.

i want to use quicknes because it's the emulator with best performance. others are stuttering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant