Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drf does not yet support django 4.2 #2498

Closed
jooola opened this issue Apr 3, 2023 · 4 comments
Closed

drf does not yet support django 4.2 #2498

jooola opened this issue Apr 3, 2023 · 4 comments
Labels
is: bug upstream This is related to an upstream issue
Milestone

Comments

@jooola
Copy link
Contributor

jooola commented Apr 3, 2023

Describe the bug

I was a bit too fast to while merging django >=4.2, drf didn't released a version that ship the latest fix to work with django 4.2.

To reproduce

Run from the current main and see the gunicorn logs.

Expected behavior

DRF should work with django 4.2

@jooola jooola added is: bug upstream This is related to an upstream issue labels Apr 3, 2023
@paddatrapper
Copy link
Contributor

Looks like we need the next DRF release - encode/django-rest-framework#8794

@jooola jooola added this to the 3.1.0 milestone Apr 3, 2023
@jooola
Copy link
Contributor Author

jooola commented Apr 11, 2023

I am tempted to install drf from the repo directly, in order to test the django 4.2 integration before they can release.

@paddatrapper Do you agree and think this isn't a bad idea ?

@paddatrapper
Copy link
Contributor

Looks like they are pretty close to a release, so there shouldn't be any major bugs that we would hit. Assuming we can easily switch back to versioned releases, then I think we should install from the repo for the moment

@jooola
Copy link
Contributor Author

jooola commented May 25, 2023

According to encode/django-rest-framework#8942 django-rest-framework 3.14 work with django 4.2.1.

DRF won't work if we have django 4.2.1 and drf <3.14, so we probably want to bump the minimal version of DRF to 3.14 and revert the installation from the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug upstream This is related to an upstream issue
Projects
None yet
Development

No branches or pull requests

2 participants