Improve player #823
Improve player #823
Conversation
Make the decoders and player use the same math for converting between samples and milliseconds.
And a small change to lewton_decoder
Make decoder seek in pcm not ms. Everytime we call decoder.seek we also need position_pcm. We can skip some redundant math and just call seek with position_pcm.
|
@roderickvd as you might have noticed, this commit pretty much goes hand in hand with #820. The 2 combined go a long way to better playback error handling. It really doesn't matter which is merged 1st. Either way I'll have to fix some conflicts. |
And remove unwraps from the decoders and panics from mod
|
Thanks for your work mate ❤️ as I've recently returned from holiday, I'll start my review somewhere the coming days. |
It's all good. I hope you had fun and are well rested. |
|
Hey @roderickvd not to press or anything but have you had a chance to look at any of this? |
|
You're quite right, you put effort into this and deserve no less than proper feedback and handling of this PR! Unfortunately though at this time "life is happening" over at my place. Rest assured I will be handling this but please give me some time to "get back at it again". In the meantime other contributors and maintainers are warmly invited to review. |
Well whatever is going on I hope it's either a good thing or at least not horrible?
OK. No problem. |
Resolves: #823 (comment), #823 (comment)
|
Hi @JasonLG1979 I think there's a few minor review points remaining, when you have time to address those, we can get this in and start rolling a whopper of a 0.3.0 release! |
|
@roderickvd I think that about covers it. |
|
Oh, geee, what a surprise |
|
Looking good, thanks mate. Do you want me to squash merge it, or do you want to squash and force push yourself? I'm fine with either, the latter offers a bit more attribution.
Yeah we'll have to tackle that sometime soon. I haven't dug around deep enough, but I even think it's caused by one of the transitive dependencies? Anyway it doesn't stand in the way for this or any other commits as far as I'm concerned. |
|
On second though, I'm going ahead with this now. I see GitHub provides proper attribution either way. 👍 |
|
57937a1 fixed the 101 exit codes. |
Make the decoders and player use the same math for converting between samples and milliseconds.
Remove unwraps, expects and panics from player, decoders and mod.
Reduce redundant math.
Simplify decoder errors with thiserror.